Revert "Correctly display tooltips for buttons in Tree when they overlap cell content #90842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lap cell content" This reverts commit 8278a5f.
timothyqiu
added
bug
topic:gui
cherrypick:4.1
akien-mga
approved these changes
Apr 18, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#79792 caches button rect when drawing, and uses that rect to determine the tooltip. However, the rectangle used for processing mouse input is not the same as the rectangle used for drawing. The tooltip is still missing in some edge cases. So I think it's not the correct fix for #79629.
It also caused a regression (#86497) making tree buttons' tooltips missing / wrong if the Tree has column titles visible which is impossible for users to workaround.
Bugsquad edit: